Skip to content

docs: replace Shader Playground links - #8887

Merged
Ashley Coleman (V-FEXrt) merged 1 commit into
microsoft:mainfrom
kavyansh18:docs/replace-shader-playground-links
Sep 10, 2026
Merged

docs: replace Shader Playground links#8887
Ashley Coleman (V-FEXrt) merged 1 commit into
microsoft:mainfrom
kavyansh18:docs/replace-shader-playground-links

Conversation

@kavyansh18

@kavyansh18 KAVYANSH KUMAR (kavyansh18) commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Description

Replaces the deprecated Shader Playground links in docs/SPIRV-Cookbook.rst with Compiler Explorer links.

The existing HLSL examples and shader code are unchanged.

Testing

  • Verified all 22 links were replaced.
  • Verified no Shader Playground links remain.
  • Ran the documentation linter.
  • Verified the documentation parses successfully.

Copilot AI balanced review requested due to automatic review settings September 5, 2026 18:31
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@kavyansh18

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only updates were validated, with no unresolved issues.

Pull request overview

Replaces deprecated Shader Playground links in the SPIR-V Cookbook with Compiler Explorer sessions.

Changes:

  • Updates introductory guidance to reference Compiler Explorer.
  • Replaces all 22 obsolete URLs while preserving existing shader examples.
File summaries
File Description
docs/SPIRV-Cookbook.rst Updates the service reference and interactive example links.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@V-FEXrt

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@alsepkow Alex Sepkowski (alsepkow) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I do think the description here reads overly verbose like generated from an LLM. The 'changes' list is largely redundant and covered by the description. Similar comment on the validation list.

@bob80905 Joshua Batista (bob80905) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@V-FEXrt

Copy link
Copy Markdown
Collaborator

KAVYANSH KUMAR (@kavyansh18) once you update the description per Alex's comment we can merge.

If you used an LLM to assist with the PR you are requirement to disclose that as part of the commit message.

Thanks for the contribution!

@kavyansh18

Copy link
Copy Markdown
Contributor Author

@V-FEXrt
Ashley Coleman (V-FEXrt) merged commit 91dfed9 into microsoft:main Sep 10, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants